Replace 10 or more consecutive underscores with 9 in word clue used in xAP… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
I wonder why someone would set the clue to underscores, but this should resolve the problem, yes.
Should the __________ placeholder in the report module (https://github.com/h5p/h5p-php-report/blob/0968db5d36b7ed5e19eff63ec06c36d75593044c/type-processors/fill-in-processor.class.php#L13) be replaced by a UUID or similar maybe? Or is it needed somewhere to also visually indicate blanks in plain mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some authors are using 10 or more consecutive underscores in the Clue field. Since we're using the 10 underscores in the xAPI statement to signal a "blank", this becomes incompatible.
I must admit I haven't tested this code change, but theorietically it should do the trick.